From 6ae87aed15feb916280a6f515e510ec1c086296a Mon Sep 17 00:00:00 2001 From: Pierre-Yves Nicolas <6371790+pynicolas@users.noreply.github.com> Date: Thu, 15 Jan 2026 11:07:47 +0100 Subject: [PATCH] ExportQuality: externalize strings --- .../java/org/fairscan/app/domain/ExportQuality.kt | 14 ++++++++++---- .../app/ui/screens/settings/SettingsScreen.kt | 14 ++++---------- app/src/main/res/values-cs/strings.xml | 5 +++++ app/src/main/res/values-de/strings.xml | 5 +++++ app/src/main/res/values-es/strings.xml | 5 +++++ app/src/main/res/values-fr/strings.xml | 5 +++++ app/src/main/res/values-it/strings.xml | 5 +++++ app/src/main/res/values-pt-rBR/strings.xml | 5 +++++ app/src/main/res/values-ru/strings.xml | 5 +++++ app/src/main/res/values-zh-rTW/strings.xml | 8 +++++--- app/src/main/res/values-zh/strings.xml | 5 +++++ app/src/main/res/values/strings.xml | 5 +++++ 12 files changed, 64 insertions(+), 17 deletions(-) diff --git a/app/src/main/java/org/fairscan/app/domain/ExportQuality.kt b/app/src/main/java/org/fairscan/app/domain/ExportQuality.kt index 050bc92..de3e1fe 100644 --- a/app/src/main/java/org/fairscan/app/domain/ExportQuality.kt +++ b/app/src/main/java/org/fairscan/app/domain/ExportQuality.kt @@ -14,20 +14,26 @@ */ package org.fairscan.app.domain +import org.fairscan.app.R + enum class ExportQuality( val jpegQuality: Int, - val maxPixels: Long + val maxPixels: Long, + val labelResource: Int ) { LOW( jpegQuality = 60, - maxPixels = 1_000_000 + maxPixels = 1_000_000, + R.string.export_quality_low, ), BALANCED( jpegQuality = 75, - maxPixels = 2_000_000 + maxPixels = 2_000_000, + R.string.export_quality_balanced, ), HIGH( jpegQuality = 80, - maxPixels = 4_000_000 + maxPixels = 4_000_000, + R.string.export_quality_high, ) } diff --git a/app/src/main/java/org/fairscan/app/ui/screens/settings/SettingsScreen.kt b/app/src/main/java/org/fairscan/app/ui/screens/settings/SettingsScreen.kt index 344e972..88ddf43 100644 --- a/app/src/main/java/org/fairscan/app/ui/screens/settings/SettingsScreen.kt +++ b/app/src/main/java/org/fairscan/app/ui/screens/settings/SettingsScreen.kt @@ -122,27 +122,21 @@ private fun SettingsContent( Spacer(Modifier.height(32.dp)) - Text("Export quality", style = MaterialTheme.typography.titleLarge) + Text(stringResource(R.string.export_quality), style = MaterialTheme.typography.titleLarge) - ExportQuality.entries.forEach { quality -> + ExportQuality.entries.reversed().forEach { quality -> Row(verticalAlignment = Alignment.CenterVertically) { RadioButton( selected = uiState.exportQuality == quality, onClick = { onExportQualityChanged(quality) }, ) - Text( - when (quality) { - ExportQuality.LOW -> "Low (smaller files)" - ExportQuality.BALANCED -> "Balanced" - ExportQuality.HIGH -> "High (best quality)" - } - ) + Text(stringResource(quality.labelResource)) } } Spacer(Modifier.height(32.dp)) - Text("Export format", style = MaterialTheme.typography.titleLarge) + Text(stringResource(R.string.export_format), style = MaterialTheme.typography.titleLarge) Row(verticalAlignment = Alignment.CenterVertically) { RadioButton( diff --git a/app/src/main/res/values-cs/strings.xml b/app/src/main/res/values-cs/strings.xml index 0b74775..10de839 100644 --- a/app/src/main/res/values-cs/strings.xml +++ b/app/src/main/res/values-cs/strings.xml @@ -25,6 +25,11 @@ Exportovat Exportovat jako %1$s Složka pro export + Formát exportu + Kvalita exportu + Nízká + Vyvážená + Vysoká Velikost souboru: %1$s Celková velikost: %1$s Název souboru diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index 3561708..ba5eb16 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -25,6 +25,11 @@ Exportieren Als %1$s exportieren Exportordner + Exportformat + Exportqualität + Niedrig + Ausgewogen + Hoch Dateigröße: %1$s Gesamtgröße: %1$s Dateiname diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index cb168de..6684f84 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -25,6 +25,11 @@ Exportar Exportar como %1$s Carpeta de exportación + Formato de exportación + Calidad de exportación + Baja + Equilibrada + Alta Tamaño del archivo: %1$s Tamaño total: %1$s Nombre del archivo diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index 389a048..2b4dbe4 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -25,6 +25,11 @@ Exporter Exporter en %1$s Dossier d’export + Format d’export + Qualité d’export + Basse + Équilibrée + Élevée Taille du fichier : %1$s Taille totale : %1$s Nom de fichier diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index b760d14..b4406af 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -25,6 +25,11 @@ Esporta Esporta come %1$s Cartella di esportazione + Formato di esportazione + Qualità di esportazione + Bassa + Bilanciata + Alta Dimensione del file: %1$s Dimensione totale: %1$s Nome file diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index 8556880..3e4b013 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -25,6 +25,11 @@ Exportar Exportar como %1$s Diretório de exportação + Formato de exportação + Qualidade de exportação + Baixa + Equilibrada + Alta Tamanho do arquivo: %1$s Tamanho total: %1$s Nome do arquivo diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 4043ecc..7bbc9a8 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -25,6 +25,11 @@ Экспорт Экспортировать как %1$s Папка экспорта + Формат экспорта + Качество экспорта + Низкое + Сбалансированное + Высокое Размер файла: %1$s Общий размер: %1$s Имя файла diff --git a/app/src/main/res/values-zh-rTW/strings.xml b/app/src/main/res/values-zh-rTW/strings.xml index 9519ef8..a095506 100644 --- a/app/src/main/res/values-zh-rTW/strings.xml +++ b/app/src/main/res/values-zh-rTW/strings.xml @@ -1,7 +1,6 @@ 關於 新增頁面 - FairScan 一個簡單且尊重隱私的文件掃描應用程式。 返回 已拒絕相機權限 @@ -20,14 +19,17 @@ 下載 (Downloads) 結束掃描 錯誤：%1$s - Failed to launch system file picker on this device - Failed to set export directory 找不到可開啟此檔案的應用程式 未偵測到文件 儲存檔案失敗 匯出 匯出為 %1$s 匯出目錄 + 匯出格式 + 匯出品質 + 低 + 平衡 + 高 檔案大小：%1$s 總計大小：%1$s 檔案名稱 diff --git a/app/src/main/res/values-zh/strings.xml b/app/src/main/res/values-zh/strings.xml index e5ede86..da54a55 100644 --- a/app/src/main/res/values-zh/strings.xml +++ b/app/src/main/res/values-zh/strings.xml @@ -25,6 +25,11 @@ 导出 导出为 %1$s 导出目录 + 导出格式 + 导出质量 + 低 + 平衡 + 高 文件大小：%1$s 总大小：%1$s 文件名字 diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index cf22aca..380d383 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -29,6 +29,11 @@ Export Export as %1$s Export directory + Export format + Export quality + Low + Balanced + High File size: %1$s Total size: %1$s Filename