From 2c64ebc972ce42917bef72aa53bde65f3f668cdd Mon Sep 17 00:00:00 2001
From: Pierre-Yves Nicolas <6371790+pynicolas@users.noreply.github.com>
Date: Sat, 23 Aug 2025 16:09:43 +0200
Subject: [PATCH] Home screen: extract strings

---
 .../java/org/mydomain/myscan/view/HomeScreen.kt     | 13 +++++--------
 app/src/main/res/values-fr/strings.xml              |  4 ++++
 app/src/main/res/values/strings.xml                 |  4 ++++
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/org/mydomain/myscan/view/HomeScreen.kt b/app/src/main/java/org/mydomain/myscan/view/HomeScreen.kt
index 61a6d1c..c06cd29 100644
--- a/app/src/main/java/org/mydomain/myscan/view/HomeScreen.kt
+++ b/app/src/main/java/org/mydomain/myscan/view/HomeScreen.kt
@@ -53,7 +53,6 @@ import org.mydomain.myscan.ui.theme.MyScanTheme
 
 @OptIn(ExperimentalMaterial3Api::class)
 @Composable
-// FIXME Extract strings
 fun HomeScreen(
     hasCameraPermission: Boolean,
     currentDocument: DocumentUiModel,
@@ -82,7 +81,7 @@ fun HomeScreen(
                         }
                     },
                     icon = Icons.Default.PhotoCamera,
-                    text = "Start a new scan",
+                    text = stringResource(R.string.start_a_new_scan),
                     modifier = Modifier
                         .padding(12.dp)
                         .height(48.dp),
@@ -101,7 +100,7 @@ fun HomeScreen(
             }
 
             if (!currentDocument.isEmpty()) {
-                SectionTitle("Current document")
+                SectionTitle(stringResource(R.string.current_document))
                 CurrentDocumentCard(currentDocument, navigation)
             }
 
@@ -125,16 +124,14 @@ private fun CameraPermissionRationale() {
     ) {
         Column(Modifier.padding(16.dp)) {
             Text(
-                "The app requires camera access to scan documents. " +
-                        "Captured images are stored only on this device and will be deleted " +
-                        "when you close the current document.",
+                stringResource(R.string.camera_permission_rationale),
                 style = MaterialTheme.typography.bodyMedium
             )
             Spacer(Modifier.height(8.dp))
             Button(onClick = {
                 requestPermissionLauncher.launch(Manifest.permission.CAMERA)
             }) {
-                Text("Grant permission")
+                Text(stringResource(R.string.grant_permission))
             }
         }
     }
@@ -167,7 +164,7 @@ private fun CurrentDocumentCard(
             Column(Modifier.weight(1f)) {
                 Text(pageCountText(currentDocument.pageCount()))
             }
-            MainActionButton(navigation.toDocumentScreen, "Open")
+            MainActionButton(navigation.toDocumentScreen, stringResource(R.string.open))
         }
     }
 }
diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml
index 374ac8c..82a7570 100644
--- a/app/src/main/res/values-fr/strings.xml
+++ b/app/src/main/res/values-fr/strings.xml
@@ -5,9 +5,11 @@
     <string name="app_tagline">Une application simple et respectueuse pour scanner vos documents.</string>
     <string name="back">Retour</string>
     <string name="camera_permission_denied">L\'autorisation d\'accès à la caméra a été refusée</string>
+    <string name="camera_permission_rationale">L’application a besoin d’accéder à l’appareil photo pour scanner des documents. Les images capturées sont enregistrées uniquement sur cet appareil et seront supprimées lorsque vous fermerez le document en cours.</string>
     <string name="cancel">Annuler</string>
     <string name="close">Fermer</string>
     <string name="close_document">Fermer le document</string>
+    <string name="current_document">Document en cours</string>
     <string name="delete_page">Supprimer la page</string>
     <string name="document">Document</string>
     <string name="error">Erreur : %1$s</string>
@@ -16,6 +18,7 @@
     <string name="error_save">Échec de l\'enregistrement du PDF</string>
     <string name="export_pdf">Exporter en PDF</string>
     <string name="filename">Nom de fichier</string>
+    <string name="grant_permission">Autoriser</string>
     <string name="libraries">Bibliothèques</string>
     <string name="libraries_intro">Cette application utilise plusieurs bibliothèques open source, notamment :</string>
     <string name="libraries_open_source">Bibliothèques open source</string>
@@ -30,6 +33,7 @@
     <string name="save">Enregistrer</string>
     <string name="share">Partager</string>
     <string name="share_pdf">Partager le PDF</string>
+    <string name="start_a_new_scan">Nouveau scan</string>
     <string name="unknown_size">Taille inconnue</string>
     <string name="version">Version</string>
     <string name="view_the_full_license">Voir la licence complète</string>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 1d9ac07..97506a3 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -5,9 +5,11 @@
     <string name="app_tagline">A simple and respectful application to scan your documents.</string>
     <string name="back">Back</string>
     <string name="camera_permission_denied">Camera permission was denied</string>
+    <string name="camera_permission_rationale">The app requires camera access to scan documents. Captured images are stored only on this device and will be deleted when you close the current document.</string>
     <string name="cancel">Cancel</string>
     <string name="close">Close</string>
     <string name="close_document">Close document</string>
+    <string name="current_document">Current document</string>
     <string name="delete_page">Delete page</string>
     <string name="document">Document</string>
     <string name="error">Error: %1$s</string>
@@ -16,6 +18,7 @@
     <string name="error_save">Failed to save PDF</string>
     <string name="export_pdf">Export PDF</string>
     <string name="filename">Filename</string>
+    <string name="grant_permission">Grant permission</string>
     <string name="libraries">Libraries</string>
     <string name="libraries_intro">This application uses several open-source libraries, including:</string>
     <string name="libraries_open_source">Open-source libraries</string>
@@ -30,6 +33,7 @@
     <string name="save">Save</string>
     <string name="share">Share</string>
     <string name="share_pdf">Share PDF</string>
+    <string name="start_a_new_scan">Start a new scan</string>
     <string name="unknown_size">Unknown size</string>
     <string name="version">Version</string>
     <string name="view_the_full_license">View the full license</string>